Skip to content
This repository has been archived by the owner on Apr 6, 2022. It is now read-only.

acquia-search-governor-php cannot read stored auth data #79

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

magtak
Copy link

@magtak magtak commented Mar 13, 2019

I know the code doesn't seem to make a lot of sense, and I cannot figure out what the bug is, but with PHP 7.1 (after the Mojave update) this very simple function

public function getClient($group, $name)
    {
        return isset($this[$group][$name]) ? $this[$group][$name] : null;
    }

... will return null even though the ArrayObject $this should have populated properties in it's storage. If you access those properties (e.g. with a print_r, or var_dump, or even assign them to a variable) before the isset is called, it all just works as expected.

Copy link

@BimaliU BimaliU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code doesn't change any behavior and also resolves the issue given.

@bhusalm-acq
Copy link

@magtak what's blocking this from getting it merged? All the ops are having to do manual steps do get governor working now. It would be great for governor.phar users if this PR can be merged and get the issue fixed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants